Prevent double clicking of the submit button on login#3554
Merged
nabokihms merged 2 commits intoJun 13, 2024
Conversation
nabokihms
requested changes
Jun 3, 2024
Member
nabokihms
left a comment
nabokihms
left a comment
There was a problem hiding this comment.
Overall the idea looks cool. Just a couple of questions.
Signed-off-by: Philip Corliss <pcorliss@drwholdings.com>
Signed-off-by: Philip Corliss <pcorliss@drwholdings.com>
pcorliss
force-pushed
the
UPPI-2578/pkc-prevent-double-clicking
branch
from
e900918 to
8ca20f2
Compare
nabokihms
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Disables the submit button on login to prevent clicking multiple times while waiting for a response from the form submission on login.
What this PR does / why we need it
When connecting to a very slow provider a response can take several seconds, without a visual indicator users click the submit button several times. After multiple clicks when a response is returned it's often a 500 error page within our setup. Better to prevent the user from submitting the form multiple times and indicating that by disabling the button.
We can solve this issue internally by having a custom frontend documented here https://dexidp.io/docs/guides/templates/ but this felt like a good thing to share more widely to help others.
Special notes for your reviewer
If necessary the following can be rewritten inline to avoid loading a unique JS file.