fix(connector): update authproxy and oauth to match CallbackConnector#4589
Merged
nabokihms merged 1 commit intoFeb 26, 2026
Merged
Conversation
… interface The PKCE support added in v2.45.0 changed the CallbackConnector interface signatures but missed updating the authproxy and oauth connectors. This caused a type assertion failure in handleConnectorLogin(), resulting in "Requested resource does not exist" errors when using these connectors. Update LoginURL to return (string, []byte, error) and HandleCallback to accept a []byte connData parameter for both connectors and their tests. Signed-off-by: Mathias Gebbe <mathias.gebbe@gmail.com>
Member
|
Thanks! I will wait a couple of days for other bugs and then release a patch. |
nabokihms
approved these changes
Feb 26, 2026
nabokihms
pushed a commit
to deckhouse/3p-dex
that referenced
this pull request
Mar 3, 2026
… interface (dexidp#4589) The PKCE support added in v2.45.0 changed the CallbackConnector interface signatures but missed updating the authproxy and oauth connectors. This caused a type assertion failure in handleConnectorLogin(), resulting in "Requested resource does not exist" errors when using these connectors. Update LoginURL to return (string, []byte, error) and HandleCallback to accept a []byte connData parameter for both connectors and their tests. Signed-off-by: Mathias Gebbe <mathias.gebbe@gmail.com>
xtremerui
pushed a commit
to concourse/dex
that referenced
this pull request
Mar 19, 2026
<!-- Release notes generated using configuration in .github/release.yml at v2.45.x --> ### Bug Fixes 🐛 - Quote `groups` reserved word in query replacer to fix MySQL 8.0+ storage migration (dexidp#4580) - Update `authproxy` and `oauth` to match CallbackConnector interface (dexidp#4589) **Full Changelog**: dexidp/dex@v2.45.0...v2.45.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #4588
In v2.45.0, PKCE support was added to the OIDC connector (commit
25591eea). This changed theCallbackConnectorinterface inconnector/connector.go:Most connectors (github, gitlab, google, oidc, microsoft, etc.) were updated to match the new interface, but authproxy and oauth were missed.
Because these two connectors no longer satisfy the
CallbackConnectorinterface, the type switch inserver/handlers.go:handleConnectorLogin()falls through to thedefaultcase, which renders the "Requested resource does not exist." error.