Skip to content

chore: remove redundant word in comment #4283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2025
Merged

chore: remove redundant word in comment #4283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f880057
chore: remove redundant word in comment
jianghuyiyuan Jun 23, 2025
5bca323
Merge branch 'master' into master
raymondk Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/cli-reference/dfx-canister.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,7 @@ You can specify the following options for the `dfx canister update-settings` com
| `--confirm-very-short-freezing-threshold` | Freezing thresholds below 1 week require this option as confirmation. |
| `--impersonate <principal>` | Specifies a principal on behalf of which requests to a local PocketIC instance are sent. |
| `--set-controller <principal>` | Specifies the identity name or the principal of the new controller. Can be specified more than once, indicating the canister will have multiple controllers. If any controllers are set with this parameter, any other controllers will be removed. |
| `--set-log-viewer <principal>` | Specifies the the principal of the log viewer of the canister. Can be specified more than once, indicating the canister will have multiple log viewers. If any log viewers are set with this parameter, any other log viewers will be removed. If current log visibility is `public` or `controllers`, it will be changed to the custom allowed viewer list. |
| `--set-log-viewer <principal>` | Specifies the principal of the log viewer of the canister. Can be specified more than once, indicating the canister will have multiple log viewers. If any log viewers are set with this parameter, any other log viewers will be removed. If current log visibility is `public` or `controllers`, it will be changed to the custom allowed viewer list. |
| `--memory-allocation <allocation>` | Specifies how much memory the canister is allowed to use in total. This should be a value in the range [0..12 GiB]. A setting of 0 means the canister will have access to memory on a "best-effort" basis: It will only be charged for the memory it uses, but at any point in time may stop running if it tries to allocate more memory when there isn't space available on the subnet. |
| `--reserved-cycles-limit <limit>` | Specifies the upper limit of the canister's reserved cycles. |
| `--wasm-memory-limit <limit>` | Specifies a soft upper limit for the canister's heap memory. |
Expand Down
2 changes: 1 addition & 1 deletion e2e/tests-dfx/info.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ teardown() {
]" > src/e2e_project_frontend/assets/.ic-assets.json5
cat src/e2e_project_frontend/assets/.ic-assets.json5

# fails if the the above produced invalid json5
# fails if the above produced invalid json5
assert_command dfx deploy
}

Expand Down
2 changes: 1 addition & 1 deletion src/dfx/src/commands/canister/create.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ pub struct CanisterCreateOpts {
#[arg(long, value_parser = log_visibility_parser, conflicts_with("log_viewer"))]
log_visibility: Option<LogVisibility>,

/// Specifies the the principal of the log viewer of the canister.
/// Specifies the principal of the log viewer of the canister.
/// Can be specified more than once.
#[arg(long, action = ArgAction::Append, value_parser = principal_parser, conflicts_with("log_visibility"))]
log_viewer: Option<Vec<candid::Principal>>,
Expand Down
2 changes: 1 addition & 1 deletion src/dfx/src/lib/canister_logs/log_visibility.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pub struct LogVisibilityOpt {
#[arg(long, action = ArgAction::Append, value_parser = principal_parser, conflicts_with("set_log_viewer"))]
remove_log_viewer: Option<Vec<Principal>>,

/// Specifies the the principal of the log viewer of the canister.
/// Specifies the principal of the log viewer of the canister.
/// Can be specified more than once.
#[arg(
long,
Expand Down
Loading