feat: Dioxus 0.5 support #36

marc2332 · 2024-03-10T10:26:07Z

Prepare support for Dioxus 0.5

Closes #26
Closes #28
Closes #14

marc2332 · 2024-03-10T10:30:08Z

~~Looks like material design icons are failed to be written, looking into it~~ Fixed

iynaix · 2024-03-26T05:45:34Z

Trying to use it with the following in Cargo.toml:

dioxus-free-icons = { git = "https://github.com/dioxus-community/dioxus-free-icons", branch = "feat/dioxus-0.5", features = [
    "material-design-icons-editor",
] }

I'm getting hundreds of errors such as:

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1816:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1816 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1837:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1837 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1858:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1858 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

Some errors have detailed explanations: E0119, E0428.
For more information about an error, try `rustc --explain E0119`.
error: could not compile `dioxus-free-icons` (lib) due to 595 previous errors
warning: build failed, waiting for other jobs to finish...

Am I missing something obvious here like having to run a codegen step?

marc2332 · 2024-03-26T08:11:41Z

Trying to use it with the following in Cargo.toml:

dioxus-free-icons = { git = "https://github.com/dioxus-community/dioxus-free-icons", branch = "feat/dioxus-0.5", features = [
    "material-design-icons-editor",
] }

I'm getting hundreds of errors such as:

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1816:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1816 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1837:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1837 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1858:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1858 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

Some errors have detailed explanations: E0119, E0428.
For more information about an error, try `rustc --explain E0119`.
error: could not compile `dioxus-free-icons` (lib) due to 595 previous errors
warning: build failed, waiting for other jobs to finish...

Am I missing something obvious here like having to run a codegen step?

No, it looks like the codegen generated is wrong, will check asap! Thanks for the report!

marc2332 · 2024-03-26T08:29:24Z

Trying to use it with the following in Cargo.toml:

dioxus-free-icons = { git = "https://github.com/dioxus-community/dioxus-free-icons", branch = "feat/dioxus-0.5", features = [
    "material-design-icons-editor",
] }

I'm getting hundreds of errors such as:

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1816:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1816 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1837:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1837 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

error[E0119]: conflicting implementations of trait `IconShape` for type `md_editor_icons::MdMaterialDesignIcons`
    --> /persist/cache/home/iynaix/.local/share/.cargo/git/checkouts/dioxus-free-icons-d246d2ebe6d920da/58f601c/packages/lib/src/icons/md_editor_icons.rs:1858:1
     |
6    | impl IconShape for MdMaterialDesignIcons {
     | ---------------------------------------- first implementation here
...
1858 | impl IconShape for MdMaterialDesignIcons {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `md_editor_icons::MdMaterialDesignIcons`

Some errors have detailed explanations: E0119, E0428.
For more information about an error, try `rustc --explain E0119`.
error: could not compile `dioxus-free-icons` (lib) due to 595 previous errors
warning: build failed, waiting for other jobs to finish...

Am I missing something obvious here like having to run a codegen step?

Try now! I think it should work

iynaix · 2024-03-26T11:22:58Z

It seems to work now (no more build errors), but I am running into #26. There's an empty path over the actual icon so it always shows up as a filled box. :(

marc2332 · 2024-03-26T11:25:32Z

It seems to work now (no more build errors), but I am running into #26. There's an empty path over the actual icon so it always shows up as a filled box. :(

Will try to fix asap!

marc2332 · 2024-03-26T13:32:25Z

It seems to work now (no more build errors), but I am running into #26. There's an empty path over the actual icon so it always shows up as a filled box. :(

Try now! I think I got it working 😄 I also updated it to alpha 2

iynaix · 2024-03-26T15:19:18Z

It's working great now! ❤️

marc2332 · 2024-03-26T15:22:05Z

It's working great now! ❤️

Awesome!

houseme · 2024-03-30T14:05:41Z

packages/example/Cargo.toml

 [dependencies]
-dioxus = { version = "0.4.0" }
-dioxus-web = { version = "0.4.0" }
+dioxus = { version = "0.5.0-alpha.0", features = ["web"] }


feat: Dioxus 0.5 support

5e3fd53

marc2332 added the enhancement New feature or request label Mar 10, 2024

fix windows codegen

58f601c

fix codegen on windows again

4d17860

marc2332 added 2 commits March 26, 2024 14:29

fixes

e31067a

bump dx

deefc23

fix ionicons

979bb25

marc2332 mentioned this pull request Mar 26, 2024

Inner stroke style on ionicons #28

Closed

make title prop optional

38510d6

bump to stable

097921b

marc2332 marked this pull request as ready for review March 28, 2024 17:14

houseme reviewed Mar 30, 2024

View reviewed changes

marc2332 added 5 commits March 30, 2024 18:02

clean up

0715554

chore: Update readme

d644eb2

okay...

3366cce

:)

8d70f79

:(

756746c

marc2332 merged commit 14493cc into main Mar 30, 2024

marc2332 deleted the feat/dioxus-0.5 branch March 30, 2024 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Dioxus 0.5 support #36

feat: Dioxus 0.5 support #36

Uh oh!

marc2332 commented Mar 10, 2024 •

edited

Loading

Uh oh!

marc2332 commented Mar 10, 2024 •

edited

Loading

Uh oh!

iynaix commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

iynaix commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024 •

edited

Loading

Uh oh!

iynaix commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

houseme Mar 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Dioxus 0.5 support #36

feat: Dioxus 0.5 support #36

Uh oh!

Conversation

marc2332 commented Mar 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc2332 commented Mar 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iynaix commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

iynaix commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iynaix commented Mar 26, 2024

Uh oh!

marc2332 commented Mar 26, 2024

Uh oh!

houseme Mar 30, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marc2332 commented Mar 10, 2024 •

edited

Loading

marc2332 commented Mar 10, 2024 •

edited

Loading

marc2332 commented Mar 26, 2024 •

edited

Loading