Skip to content

feat: voice v8 payloads & MLS voice opcodes #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025

Conversation

Snazzah
Copy link
Contributor

@Snazzah Snazzah commented Jun 2, 2025

Please describe the changes this PR makes and why it should be merged:
This adds the voice opcodes necessary for using Discord's DAVE protocol.

Sidenote, during testing I don't think I've ever ran into opcode 12, which apparently used to emit when someone joins along with their SSRC, but this doesn't seem to emit anymore and instead opcode 11 is emitted as an array of user IDs, so I deprecated this opcode.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
discord/discord-api-docs#7150

@Snazzah Snazzah requested review from a team as code owners June 2, 2025 01:57
Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 9:13pm

@Snazzah Snazzah changed the title feat: add MLS voice opcodes feat: voice v8 & MLS voice opcodes Jun 2, 2025
@Snazzah Snazzah changed the title feat: voice v8 & MLS voice opcodes feat: voice v8 payloads & MLS voice opcodes Jun 2, 2025
@vladfrangu vladfrangu merged commit ebf313c into discordjs:main Jun 2, 2025
4 of 5 checks passed
@Snazzah Snazzah deleted the feat/mls-voice-opcodes branch June 2, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants