Skip to content

feat(voice): use voice gateway v8 #10918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

Conversation

Snazzah
Copy link
Contributor

@Snazzah Snazzah commented Jun 2, 2025

Please describe the changes this PR makes and why it should be merged:

Implements the changes necessary for Voice Gateway V8, mainly just adding buffered resume and keeping track of the sequence number in VoiceWebSocket.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@Snazzah Snazzah requested a review from a team as a code owner June 2, 2025 02:59
Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2025 5:36pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2025 5:36pm

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 42.49%. Comparing base (e094faf) to head (0318839).

Files with missing lines Patch % Lines
packages/voice/src/networking/Networking.ts 10.00% 9 Missing ⚠️
packages/voice/src/networking/VoiceWebSocket.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10918      +/-   ##
==========================================
- Coverage   42.73%   42.49%   -0.24%     
==========================================
  Files         262      262              
  Lines       16073    16016      -57     
  Branches     1545     1524      -21     
==========================================
- Hits         6868     6806      -62     
- Misses       9193     9198       +5     
  Partials       12       12              
Flag Coverage Δ
voice 70.45% <5.55%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite added this to the voice 0.19.0 milestone Jun 2, 2025
Copy link
Member

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first step towards being able to support DAVE 👍

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Jun 2, 2025
@kodiakhq kodiakhq bot merged commit d40ceed into discordjs:main Jun 2, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jun 2, 2025
@Snazzah Snazzah deleted the feat/voice-v8 branch June 3, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants