-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(voice): implement DAVE end-to-end encryption #10921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
return Davey?.DAVE_PROTOCOL_VERSION; | ||
} | ||
|
||
export interface DAVESession extends EventEmitter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use asynceventemitter like in other packages if you can (unless voice doesn't use it yet, in which case i can look into moving us there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Networking class nor the VoiceConnection don't seem to use asynceventmitter yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it then
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10921 +/- ##
==========================================
- Coverage 42.69% 42.00% -0.70%
==========================================
Files 262 264 +2
Lines 16086 16407 +321
Branches 1545 1546 +1
==========================================
+ Hits 6868 6891 +23
- Misses 9206 9504 +298
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please describe the changes this PR makes and why it should be merged:
Implements the Discord Audio & Video End-to-End Encryption (DAVE) Protocol (PR) using
@snazzah/davey
.Status and versioning classification: