collect events continuously from an engine#2717
collect events continuously from an engine#2717dongluochen wants to merge 1 commit intodocker-archive:masterfrom
Conversation
Signed-off-by: Dong Chen <dongluo.chen@docker.com>
|
The test failure on Docker 1.9 is caused by incompatible event API change. Docker 1.9 and before only accepts From Docker 1.10, |
|
We have several options:
|
|
How about we deprecate 1.9 with the upcoming release? I would even propose that we deprecate all versions before 1.12 soon, because 1.12 is almost a year old now. WDYT? |
|
@nishanttotla I'm ok to deprecate support for Docker 1.9 which is 2 years old. I'm a little hesitated to deprecate support for Docker-1.10 and 1.11. Production takes a long time to evolve. |
|
Docker 1.9 is now deprecated and removed from the CI. We can move ahead with this PR. @dongluochen let me know if you're able to rebase, otherwise I can carry it. |
Swarm manager collects events from each engine thru
eventsAPI. Event stream from an engine may be broken for various reasons. While manager reconnects to collect events, events from that engine between reconnects are lost. This PR remembers the timestamp of last event from an engine, and uses it with--sinceto get the missing events.Signed-off-by: Dong Chen dongluo.chen@docker.com