Merged
Conversation
PR-URL: docker-library#1120 Related: nodejs/docker-node#56 nodejs/node#3337 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Member
|
LGTM |
Member
|
LGTM, Build test of #1120; ac72b82 ( $ url="https://raw.githubusercontent.com/docker-library/official-images/ac72b821066329aeeef9393391b401d5703380b8/library/node"
$ bashbrew build "$url"
Fetching node (git://github.com/nodejs/docker-node) ...
Processing node:0.10.40 ...
Processing node:0.10 ...
Processing node:0.10.40-onbuild ...
Processing node:0.10-onbuild ...
Processing node:0.10.40-slim ...
Processing node:0.10-slim ...
Processing node:0.10.40-wheezy ...
Processing node:0.10-wheezy ...
Processing node:0.12.7 ...
Processing node:0.12 ...
Processing node:0 ...
Processing node:0.12.7-onbuild ...
Processing node:0.12-onbuild ...
Processing node:0-onbuild ...
Processing node:0.12.7-slim ...
Processing node:0.12-slim ...
Processing node:0-slim ...
Processing node:0.12.7-wheezy ...
Processing node:0.12-wheezy ...
Processing node:0-wheezy ...
Processing node:4.2.1 ...
Processing node:4.2 ...
Processing node:4 ...
Processing node:latest ...
Processing node:4.2.1-onbuild ...
Processing node:4.2-onbuild ...
Processing node:4-onbuild ...
Processing node:onbuild ...
Processing node:4.2.1-slim ...
Processing node:4.2-slim ...
Processing node:4-slim ...
Processing node:slim ...
Processing node:4.2.1-wheezy ...
Processing node:4.2-wheezy ...
Processing node:4-wheezy ...
Processing node:wheezy ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing node:0.10.40
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.10.40-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.10.40-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.10.40-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:0.12.7-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1-onbuild
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1-slim
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed
testing node:4.2.1-wheezy
'utc' [1/5]...passed
'cve-2014--shellshock' [2/5]...passed
'no-hard-coded-passwords' [3/5]...passed
'override-cmd' [4/5]...passed
'node-hello-world' [5/5]...passed |
Contributor
Author
|
Thanks for the quick merge of this guys! 😅🚀 |
Member
|
I figured a new release on the next day was fairly important and you guys make it so easy to review 😃👍. |
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
PR-URL: docker-library#1120 Related: nodejs/docker-node#56 nodejs/node#3337 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update node to v4.2.1.
Changeset: nodejs/docker-node@184653e...04df868
Related: nodejs/docker-node#56 nodejs/node#3337
Signed-off-by: Hans Kristian Flaatten hans.kristian.flaatten@turistforeningen.no