-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Node: chore: Drop EOL Node.js 18 #19118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Diff for 7a83369:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 974dceb..3830d41 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -2,36 +2,6 @@ Maintainers: The Node.js Docker Team <https://github.com/nodejs/docker-node> (@n
GitRepo: https://github.com/nodejs/docker-node.git
GitFetch: refs/heads/main
-Tags: 18, 18-bookworm, 18.20, 18.20-bookworm, 18.20.8, 18.20.8-bookworm, hydrogen, hydrogen-bookworm
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: ba2b3e61e6aaf4643108fb5f1cda9ee5238efde5
-Directory: 18/bookworm
-
-Tags: 18-alpine, 18-alpine3.21, 18.20-alpine, 18.20-alpine3.21, 18.20.8-alpine, 18.20.8-alpine3.21, hydrogen-alpine, hydrogen-alpine3.21
-Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: ba2b3e61e6aaf4643108fb5f1cda9ee5238efde5
-Directory: 18/alpine3.21
-
-Tags: 18-alpine3.20, 18.20-alpine3.20, 18.20.8-alpine3.20, hydrogen-alpine3.20
-Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: ba2b3e61e6aaf4643108fb5f1cda9ee5238efde5
-Directory: 18/alpine3.20
-
-Tags: 18-bookworm-slim, 18-slim, 18.20-bookworm-slim, 18.20-slim, 18.20.8-bookworm-slim, 18.20.8-slim, hydrogen-bookworm-slim, hydrogen-slim
-Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
-GitCommit: ba2b3e61e6aaf4643108fb5f1cda9ee5238efde5
-Directory: 18/bookworm-slim
-
-Tags: 18-bullseye, 18.20-bullseye, 18.20.8-bullseye, hydrogen-bullseye
-Architectures: amd64, arm32v7, arm64v8
-GitCommit: ba2b3e61e6aaf4643108fb5f1cda9ee5238efde5
-Directory: 18/bullseye
-
-Tags: 18-bullseye-slim, 18.20-bullseye-slim, 18.20.8-bullseye-slim, hydrogen-bullseye-slim
-Architectures: amd64, arm32v7, arm64v8
-GitCommit: ba2b3e61e6aaf4643108fb5f1cda9ee5238efde5
-Directory: 18/bullseye-slim
-
Tags: 20, 20-bookworm, 20.19, 20.19-bookworm, 20.19.2, 20.19.2-bookworm, iron, iron-bookworm
Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
GitCommit: a87fa26c1bb455170dac58c57c661e820a7390cb
diff --git a/_bashbrew-list b/_bashbrew-list
index 5a29359..d5e04a1 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,30 +1,3 @@
-node:18
-node:18-alpine
-node:18-alpine3.20
-node:18-alpine3.21
-node:18-bookworm
-node:18-bookworm-slim
-node:18-bullseye
-node:18-bullseye-slim
-node:18-slim
-node:18.20
-node:18.20-alpine
-node:18.20-alpine3.20
-node:18.20-alpine3.21
-node:18.20-bookworm
-node:18.20-bookworm-slim
-node:18.20-bullseye
-node:18.20-bullseye-slim
-node:18.20-slim
-node:18.20.8
-node:18.20.8-alpine
-node:18.20.8-alpine3.20
-node:18.20.8-alpine3.21
-node:18.20.8-bookworm
-node:18.20.8-bookworm-slim
-node:18.20.8-bullseye
-node:18.20.8-bullseye-slim
-node:18.20.8-slim
node:20
node:20-alpine
node:20-alpine3.20
@@ -149,15 +122,6 @@ node:current-bookworm-slim
node:current-bullseye
node:current-bullseye-slim
node:current-slim
-node:hydrogen
-node:hydrogen-alpine
-node:hydrogen-alpine3.20
-node:hydrogen-alpine3.21
-node:hydrogen-bookworm
-node:hydrogen-bookworm-slim
-node:hydrogen-bullseye
-node:hydrogen-bullseye-slim
-node:hydrogen-slim
node:iron
node:iron-alpine
node:iron-alpine3.20
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index 0f7a733..65cb1b5 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -8,12 +8,6 @@ node:current-alpine3.20
node:current-alpine3.21
node:current-bullseye
node:current-bullseye-slim
-node:hydrogen-alpine3.20
-node:hydrogen-alpine3.21
-node:hydrogen-bookworm
-node:hydrogen-bullseye
-node:hydrogen-bullseye-slim
-node:hydrogen-slim
node:iron-alpine3.20
node:iron-alpine3.21
node:iron-bookworm
diff --git a/node_hydrogen-alpine3.20/Dockerfile b/node_hydrogen-alpine3.20/Dockerfile
deleted file mode 100644
index 6c1eef4..0000000
diff --git a/node_hydrogen-alpine3.20/docker-entrypoint.sh b/node_hydrogen-alpine3.20/docker-entrypoint.sh
deleted file mode 100755
index 1b3116e..0000000
diff --git a/node_hydrogen-alpine3.21/Dockerfile b/node_hydrogen-alpine3.21/Dockerfile
deleted file mode 100644
index 1648f84..0000000
diff --git a/node_hydrogen-alpine3.21/docker-entrypoint.sh b/node_hydrogen-alpine3.21/docker-entrypoint.sh
deleted file mode 100755
index 1b3116e..0000000
diff --git a/node_hydrogen-bookworm/Dockerfile b/node_hydrogen-bookworm/Dockerfile
deleted file mode 100644
index 14adf24..0000000
diff --git a/node_hydrogen-bookworm/docker-entrypoint.sh b/node_hydrogen-bookworm/docker-entrypoint.sh
deleted file mode 100755
index 1b3116e..0000000
diff --git a/node_hydrogen-bullseye-slim/Dockerfile b/node_hydrogen-bullseye-slim/Dockerfile
deleted file mode 100644
index a43666f..0000000
diff --git a/node_hydrogen-bullseye-slim/docker-entrypoint.sh b/node_hydrogen-bullseye-slim/docker-entrypoint.sh
deleted file mode 100755
index 1b3116e..0000000
diff --git a/node_hydrogen-bullseye/Dockerfile b/node_hydrogen-bullseye/Dockerfile
deleted file mode 100644
index 3171534..0000000
diff --git a/node_hydrogen-bullseye/docker-entrypoint.sh b/node_hydrogen-bullseye/docker-entrypoint.sh
deleted file mode 100755
index 1b3116e..0000000
diff --git a/node_hydrogen-slim/Dockerfile b/node_hydrogen-slim/Dockerfile
deleted file mode 100644
index f92eb4e..0000000
diff --git a/node_hydrogen-slim/docker-entrypoint.sh b/node_hydrogen-slim/docker-entrypoint.sh
deleted file mode 100755
index 1b3116e..0000000 Relevant Maintainers:
|
tianon
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI affected maintainers for the Node.js 18 EOL/removal:
ghost
: @tianon @yosifkit @acburdine
Please either drop the affected tags from the supported list (by removing them from your library/
file) or update them to a supported release. 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: nodejs/docker-node#2241
@LaurentGoderre @PeterDaveHello @SimenB @Starefossen @nschonni @ttshivers