Skip to content

scripts/warn-outside-container: fix escapes #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kolyshkin wants to merge 1 commit into from
Closed

scripts/warn-outside-container: fix escapes #4211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions scripts/warn-outside-container
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env sh
#!/usr/bin/env bash
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there anything in the script requiring bash now, or would sh still work?

Copy link
Copy Markdown
Contributor Author

@kolyshkin kolyshkin Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting myself

Also, use bash instead of sh because in POSIX shell echo does not take any options.

Copy link
Copy Markdown
Contributor Author

@kolyshkin kolyshkin Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative is to change all echo calls to printf (and add \n everywhere).

set -eu

target="${1:-}"
Expand All @@ -11,14 +11,14 @@ if [ -z "${DISABLE_WARN_OUTSIDE_CONTAINER:-}" ]; then
*)
(
echo
echo "\033[1mWARNING\033[0m: you are not in a container."
echo -e "\033[1mWARNING\033[0m: you are not in a container."
echo
echo 'Use "\033[1mmake dev\033[0m" to start an interactive development container,'
echo "use \"\033[1mmake -f docker.Makefile $target\033[0m\" to execute this target"
echo "in a container, or set \033[1mDISABLE_WARN_OUTSIDE_CONTAINER=1\033[0m to"
echo "disable this warning."
echo -e 'Use "\033[1mmake dev\033[0m" to start an interactive development container,'
echo -e "use \"\033[1mmake -f docker.Makefile $target\033[0m\" to execute this target"
echo -e "in a container, or set \033[1mDISABLE_WARN_OUTSIDE_CONTAINER=1\033[0m to"
echo -e "disable this warning."
echo
echo "Press \033[1mCtrl+C\033[0m now to abort, or wait for the script to continue.."
echo -e "Press \033[1mCtrl+C\033[0m now to abort, or wait for the script to continue.."
echo
) >&2
sleep 5
Expand Down