Use preexec_func always#2920
Merged
Merged
Conversation
`preexec_func` is still None if it is win32 Signed-off-by: q0w <43147888+q0w@users.noreply.github.com>
milas
reviewed
Jul 29, 2022
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
Can you explain the issue you're trying to solve here?
preexec_fn is set for non-Windows platforms only:
docker-py/docker/transport/sshconn.py
Lines 48 to 52 in b2a18d7
Contributor
Author
|
so if windows it would still be none docker-py/docker/transport/sshconn.py Line 48 in b2a18d7 So you dont need to check it twice |
milas
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preexec_funcis still None if it is win32