Fixes and improvements

[kinday]

This PR fixes various issues and introduces CI improvements. There are no functional changes, only stylistic and/or infrastructure fixes. Issues were encountered during work on other contribution when I attempted to run make test.

Fix flake8 errors (e1a203f)

make test was failing due to several formatting issues, mostly line width. I have reformatted code in multiple places to make flake8 happy¹.

Fix integration tests race condition (89bce10)

Integration tests were crashing as they were starting before Docker-in-Docker container was ready to accept connections. This was reported in #996 and sleep is not a viable fix as DinD startup time varies.

I have updated Makefile² to run netcat in busybox image. This solution is used instead of running netcat on host system for two reasons: the binary might not be present and container could be unreachable from host network³

Run integration tests on CI (d28f522)

Integration test suite does not fully pass on macOS thus I have updated workflow to run them on CI. This could help people with compatibility issues and ensure that proposed changes are not breaking anything.

Update: I’ve noticed integration tests are being run on Jenkins. Maybe this one could be removed, but running them via GHA allows to get them executed before PR was created, i.e. in contributor’s repository and give early feedback.

Use existing DIND version (924e09a)

The 20.10.05 tag is no longer available on Docker Hub. I have replaced it with 20.10 as this seems to be more resilient than specifying full tag.

Footnotes

1. I am not sure if I formatted the code according to Python code style; please tell if it should it be indented/splitted differently. ↩

2. I took liberty to partially reformat Makefile and replace shorthand flags with longhand ones for readability. I can either revert the changes, or apply the same style to whole file or keep things as is. Your call. ↩

3. Could be observed on macOS as Docker is being run in virtual machine and the only way to access container is to bind ports to host network. ↩

[kinday]

This should probably look like this according to other places:

Suggested change

	decode=True
	):
	decode=True):

[kinday]

This should probably look like this according to other places:

Suggested change

	client.api.create_host_config(port_bindings={1111: (
	'127.0.0.1',
	4567
	)})
	client.api.create_host_config(
	port_bindings={1111: ('127.0.0.1', 4567)})

[milas]

Thank you for the fixes and improvements! I just brought this branch up to date. The integration test wait fix is much appreciated ✌️