-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[feat] added azure pipelines guide #22777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[feat] added azure pipelines guide #22777
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristiyan-velkov good job! I left a small comment to simplify the guide for potential readers.
Furthermore, in the GHA Guide, instead of providing the complete action at the beginning of the guide, David posted parts of it explaining in details what each of them does. In my opinion, his approach is better considering readers' knowledge level.
What do you think?
@kasunsjc , @brandonh6k , @HofmeisterAn , @jmaitrehenry, @igor-alexandrov Could you please review the code again when you get a chance? |
Co-authored-by: Julien Maitrehenry <[email protected]>
Co-authored-by: Julien Maitrehenry <[email protected]>
Co-authored-by: Julien Maitrehenry <[email protected]>
Also update the |
….com:kristiyan-velkov/docker-docs into feat/introduction-to-azure-pipelines
@kristiyan-velkov I checked the PR again. It definitely became better, but the thing I originally pointed to – the unneeded |
Done! |
Done! |
Thanks for checking again! |
Testing, security check and deployment can be done in jobs. This is what the official documentation says:
My opinion here is that this guide is for beginner level engineers and it should be as simple and clear as possible. |
Good point 🙂 |
This PR introduces a new CI pipeline using Azure Pipelines to automate the process of building and pushing Docker images to Docker Hub.