duration: extract roundDuration helper and round consistently#51
Open
sahilsGit wants to merge 1 commit into
Open
duration: extract roundDuration helper and round consistently#51sahilsGit wants to merge 1 commit into
sahilsGit wants to merge 1 commit into
Conversation
Consolidates ad-hoc rounding (int(d.Hours()+0.5)) and integer truncation into a single roundDuration helper, so days/weeks/months/years all use round-half-up semantics. Adds day/week/month/year constants and extends tests for the new rounding behavior. Refs #6891 Signed-off-by: Sahil Singh <sahiilsiingh37@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates ad-hoc rounding (
int(d.Hours()+0.5)) and integer truncation into a singleroundDurationhelper, so days/weeks/months/years all use round-half-up semantics. Addsday/week/month/yearconstants and extends tests.Refs #6891
- What I did
Made
HumanDurationround consistently across all units. Previously only the hours branch rounded; days/weeks/months/years truncated, so e.g.2w4dreported"2 weeks"instead of the closer"3 weeks".- How I did it
day/week/month/yearconstants.roundDuration(d, unit) intusing round-half-up.roundDurationand switched thresholds to duration-based comparisons (d < 2*week).2w4d → "3 weeks".- How to verify it
go test -run TestHumanDuration -v