Skip to content

Feat: Prevent focus on hidden sidebar #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhildenbiddle merged 3 commits into from
Nov 16, 2023
Merged

Feat: Prevent focus on hidden sidebar #2265

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e6c88
Prevent focus on hidden sidebar
jhildenbiddle Oct 14, 2023
4aa7581
Merge branch 'develop' into 2225-sidebar-focus
jhildenbiddle Oct 17, 2023
12b2683
Merge branch 'develop' into 2225-sidebar-focus
jhildenbiddle Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/themes/basic/_layout.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ main.hidden
top 0
bottom 0
left 0
transition transform 250ms ease-out
transition transform 250ms ease-out, visibility 250ms
width $sidebar-width
z-index 20

Expand Down Expand Up @@ -406,6 +406,7 @@ body.sticky

body.close
.sidebar
visibility hidden
transform translateX(- $sidebar-width)

.sidebar-toggle
Expand Down Expand Up @@ -434,8 +435,9 @@ body.close
overflow-x hidden

.sidebar
visibility hidden
left - $sidebar-width
transition transform 250ms ease-out
transition transform 250ms ease-out, visibility 250ms

.content
left 0
Expand All @@ -454,6 +456,7 @@ body.close

body.close
.sidebar
visibility visible
transform translateX($sidebar-width)

.sidebar-toggle
Expand Down