Crash due to null pointer when picking up card

[Copper130]

When I pick up the last card on the second row it results in my flipper crashing with a null pointer as the reason for the crash. Not sure if this is exclusive to the second row, that is just the row it was happening to for me.

The issue does not seem to happen everytime but it's more often than not.

Cheers

[Copper130]

This is what the flipper returns after restarting

Additionally I have kept playing and the issue appears seemingly at random when picking up any card from one of the columns not just the last one.

Not sure if this is an issue on my part but it doesn't appear to be an issue in any other app on the flipper.

[doofy-dev]

Hi, this is strange, haven't seen null pointer issue in a while with this game 😄

Can you please tell me what firmware you are using and if you built it yourself or got the build from somewhere?

[Copper130]

Yeah I'm using momentum 10 and just used momentum's web flasher to update it.

Played lots before and after the update and only am running into it now.

[doofy-dev]

The game did not had any update since march, I have to check what they have there, if they changed anything or not. Had cases before where custom firmwares broke the game without me even knowing about either the change or that it was broken.

[Copper130]

Before I had updated the firmware I was on a version that still allowed you to place any card from the discard into the first column.

Let me know if there's anything else I can do to help you.

[doofy-dev]

Hi, so I went through the solitaire codebase momentum has, there is no change there that could cause issues like this.
Tried to break the game on OFW but so far it looks like the app is stable there, I was able to finish multiple round without any issue.

What I suspect happening is that the firmware is using more resources than expected and that breaks the memory allocation in solitaire. I remember seeng random NULL pointer errors in solitaire while I was working on the f0ge engine. I think something similar could be happening here too, either there is an application that spams the memory with junk and does not clean it up, or there is simply not enough memory left in times where it crashes.
Also there is a chance that whatever tweak Momentum does breaks the app.

I'll go through the code by the next update and safeguard memory calls everywhere in hope that it will fix this.

While I'm working on that, can you please check if it also happens on OFW for you?

[Copper130]

Yep I can. I'll do that tomorrow sometime and get back to you