Skip to content

Provide an AnchorScroll replacement that gives more flexibility. #15

@jeme

Description

@jeme
Contributor

This could also be another service that simply used AnchorScroll as default behavior (depending on it) and then extends it.

Things that should be possible is to scroll to elements defined by a route parameter etc.

Activity

jeme

jeme commented on May 6, 2013

@jeme
ContributorAuthor
added a commit that references this issue on May 13, 2013
jeme

jeme commented on Jun 28, 2013

@jeme
ContributorAuthor

This isn't quite as easy as one could have hoped, as controllers etc. loads data into views causing re-rendering, the scrolling as is may actually scroll to a wrong location.

And waiting for the views to load fully is actually suddenly a difficult task inside Angular's design, unless we provide some sort of "signalling" for the developers to use inside controllers which i just feel is a bad idea all together.

So maybe turning this on it's head and providing the service combined with a directive that can then scroll ones it's element is loaded may provide a better option, although I could still see some cases where it would maybe scroll and then render new content above again causing the scroll location to be wrong.

jeme

jeme commented on Jul 29, 2013

@jeme
ContributorAuthor

4694bea closes this issue for now, an improvement issue for this has been raised, but for now the functionality is in there at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jeme

        Issue actions

          Provide an AnchorScroll replacement that gives more flexibility. · Issue #15 · dotJEM/angular-routing