[10.0-preview.1] ASP.NET `RouteHandlerAnalyzer` - `System.IndexOutOfRangeException`

[erwinkramer]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

I see some warnings like:

CSC : warning AD0001: Analyzer 'Microsoft.AspNetCore.Analyzers.RouteHandlers.RouteHandlerAnalyzer' threw an exception of type 'System.IndexOutOfRangeException' with message 'Index was outside the bounds of the array.'. [c:\Users\erwin\bank-api\BankApi.Service.Stable\BankApi.Service.Stable.csproj]

When i build the .NET 10 version of my project: https://github.com/erwinkramer/bank-api/tree/feature/dotnet10, it didn't happen on .NET 9. See the diff here: https://github.com/erwinkramer/bank-api/pull/6/files

Expected Behavior

Should just be as .NET 9, no warnings.

Steps To Reproduce

Build .NET 9 version on: https://github.com/erwinkramer/bank-api/tree/main - this doesn't throw the warnings
Build .NET 10 version on: https://github.com/erwinkramer/bank-api/tree/feature/dotnet10 - this throws the warnings

Exceptions (if any)

No response

.NET Version

10.0.100-preview.1.25120.13

Anything else?

Using VS Code

[captainsafia]

@erwinkramer Thanks for filing this issue!

We haven't changed anything in our RouteHandlerAnalyzers for .NET 10 and a skim of the issue diff reveals that there hasn't been a change in any of the actual endpoints that have been registered. That leaves me a bit preplexed about what a repro for the issue might be.

The binlog does reveal the source of the exception in more detail:

at Microsoft.AspNetCore.Analyzers.RouteHandlers.RouteHandlerAnalyzer.DisallowNonParsableComplexTypesOnParameters(OperationAnalysisContext& context, WellKnownTypes wellKnownTypes, RouteUsageModel routeUsage, IMethodSymbol methodSymbol)

I suspect the most likely source of the issue is this line of code.

Any interest in submitting a PR to harden the item access we do here? We can try doing a length check on the type arguments before accessing.

[erwinkramer]

@captainsafia thanks, I'm willing to give it a try. For your code suggestion, i assume you mean something like this erwinkramer@c10fd48.

To validate this, I started with https://github.com/dotnet/aspnetcore/blob/main/docs/BuildFromSource.md. At:

cd src/Framework
./build.cmd

I'm getting:

 Microsoft.AspNetCore.App.Runtime failed with 1 error(s) (0,0s)
    C:\Users\erwin\.nuget\packages\microsoft.dotnet.build.tasks.installers\10.0.0-beta.25106.4\build\wix\wix.targets(149,11): error MSB4006: There is a circular dependency in the target dependency graph involving target "PublishFilesForWixInstaller".

Extra Info:

• I assumed i maybe needed the Wix dependency, as specified here as optional, so i installed it anyway, but no effect: https://github.com/dotnet/aspnetcore/blob/main/docs/BuildFromSource.md#optional-dependencies
• I'm using main @ 1f82fa5 and tried the previous commit as well
• For dependencies via Visual Studio, I used the Community version, via ./eng/scripts/InstallVisualStudio.ps1 Community Preview.

After i can get it to work, what would be the best way to step into this specific code while debugging?

[captainsafia]

@erwinkramer Sorry for the issues you ran into with the build. I'll admit that I dev primarily on Mac OS so tend to not exercise some of the Windows-specific codepaths.

@wtgodbe Does this error seem familiar to you?

On the other hand, @benhopkinstech has taken a stab at a bug fix for this. We just need to figure out what endpoint on the Bank API is exactly causing this issue.

[benhopkinstech]

@erwinkramer I have cloned your repository now

I seem to be experiencing these errors even when building your .NET 9 version (main branch)