Skip to content

Add AllowedUsernameCharacters to InvalidUserName error #62111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add AllowedUsernameCharacters to InvalidUserName error #62111

wants to merge 2 commits into from

Conversation

@SourceCodeWhen
Copy link

@SourceCodeWhen SourceCodeWhen commented May 27, 2025

Add AllowedUsernameCharacters to InvalidUserName error

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Added the AllowedUsernameCharacters string to the InvalidUserName error message. This constitutes a change to the public API so would be best to double check everything is ok before merging. Maybe an overload for this method would be better for backwards compatibility? Just let me know! :)

Fixes #39375

@SourceCodeWhen SourceCodeWhen requested review from a team and tdykstra as code owners May 27, 2025 03:43
@github-actions github-actions bot added the area-identity Includes: Identity and providers label May 27, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 27, 2025
@build-analysis build-analysis bot mentioned this pull request May 27, 2025
Open
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 3, 2025

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 3, 2025
akshay-zz
akshay-zz reviewed Oct 15, 2025
View reviewed changes
src/Identity/Extensions.Core/src/Resources.resx
Copy link

@akshay-zz akshay-zz Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert whitespaces changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdykstra tdykstra Awaiting requested review from tdykstra tdykstra is a code owner

1 more reviewer

@akshay-zz akshay-zz akshay-zz left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Identity: Message for invalid username does not reflect actual permitted characters.

2 participants

@SourceCodeWhen @akshay-zz