[StaticWebAssets] Fix duplicate asset detection in GroupAssetsByTargetPath #52281
+188
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
GenerateStaticWebAssetsManifestfails to detect conflicting static web assets when they have differentRelativePathpatterns that resolve to the same target path after token replacement.Problem
When a file in
wwwrootmatches the naming pattern of a scoped CSS bundle (e.g.,MyApp.styles.css), the build fails with:The root cause is that
GroupAssetsByTargetPathused the 2-argumentComputeTargetPath("", '/')which keeps fingerprint tokens in the path, whileGenerateStaticWebAssetsDevelopmentManifestuses the 3-argument version withStaticWebAssetTokenResolver.Instancewhich replaces tokens.Fix
Use
StaticWebAssetTokenResolver.InstanceinGroupAssetsByTargetPathto ensure consistent conflict detection.Testing
StaticWebAssetTest.csto verify the fixGenerateStaticWebAssetsManifestTesttests pass