[dotnet-svcutil] Fully qualify IXmlSerializable to ensure correct resolution #5746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imcarolwang
changed the title
HongGit
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
PR Overview
This pull request ensures the correct resolution of IXmlSerializable by fully qualifying its namespace to System.Xml.Serialization.IXmlSerializable, addressing issue #5638 and preventing misidentification of reusable types.
- Update in Globals.cs to fully qualify IXmlSerializable
- Addition of a new global tool test to validate reusable type resolution
- Inclusion of generated service reference code for compatibility
Reviewed Changes
| File | Description |
|---|---|
| src/dotnet-svcutil/lib/tests/Baselines/ReuseIXmlSerializabaleType/ReuseIXmlSerializabaleType/ServiceReference/Reference.cs | Auto-generated service reference code |
| src/dotnet-svcutil/lib/tests/src/GlobalToolTests.cs | Added global tool test to verify type reuse behavior |
| src/dotnet-svcutil/lib/src/FrameworkFork/System.Runtime.Serialization/System/Runtime/Serialization/Globals.cs | Changed IXmlSerializable to fully qualified System.Xml.Serialization.IXmlSerializable |
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #5638: Fully qualify IXmlSerializable with the correct namespace to ensure proper identification of reusable referenced types. Without this fix, it resolves to the renamed type in the forked framework, causing Globals.TypeOfIXmlSerializable.IsAssignableFrom(type) to incorrectly return false for user-defined types, resulting in them being treated as non-reusable.