Fix XamlDirective stack overflow exception #10314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
Wouldn't it be enough if you did private static MemberReflector s_UnknownReflector;
internal static MemberReflector UnknownReflector => s_UnknownReflector ??= CreateUnknownReflector(); |
|
Is there a reason why we're not keeping lazy-init, just making it TS instead? |
|
It was lazy because static fields only get assigned when necessary and in this case CreateUnknownReflector was only called on the first call to UnknownReflector and it was thread-safe because static constructors are thread safe. I pushed a commit to change it to make the lazy init explicit and more clear. |
…ective-stack-overflow-exception # Conflicts: # src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/MemberReflector.cs
|
I pulled main to fix the conflicts. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10314 +/- ##
===================================================
+ Coverage 11.45872% 11.54691% +0.08819%
===================================================
Files 3214 3214
Lines 648458 648459 +1
Branches 71511 71511
===================================================
+ Hits 74305 74877 +572
+ Misses 572989 572330 -659
- Partials 1164 1252 +88
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10313
Description
I changed MemberReflector.UnknownReflector to be thread safe by initializing the property from the static constructor instead of doing the lazy initialization manually. The static constructor of a type is guaranteed to be called only once.
See the issue for an explanation of the bug and how it's hit.
Customer Impact
Could fix a crash or weird behavior at runtime but it's very hard to hit (See issue).
Regression
No.
Testing
Used the repro in the issue which crashed before this PR and passes with this PR.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow