[StyleCleanUp] Fix misplaced using directives in CSP (IDE0065) #10683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10683 +/- ##
===================================================
- Coverage 11.28308% 11.25779% -0.02530%
===================================================
Files 3353 3353
Lines 668062 668062
Branches 74980 74980
===================================================
- Hits 75378 75209 -169
- Misses 591433 591606 +173
+ Partials 1251 1247 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jizc
reviewed
Mar 31, 2025
h3xds1nz
added a commit
to h3xds1nz/wpf
that referenced
this pull request
Apr 1, 2025
h3xds1nz
added a commit
to h3xds1nz/wpf
that referenced
this pull request
Apr 1, 2025
siagupta0202
approved these changes
Apr 4, 2025
|
@h3xds1nz Thank you for your contribution! |
|
@siagupta0202 Thank you for approving :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10682
Description
This fixes
usingplacements in CSP which I've overlooked when I've removed it in #10374 as we still don't runMilCodeGenduring build, hence this fixes that + also corrects the header for IDE0073 for generated files from the last commit.Customer Impact
Cleaner codebase for developers, being able to run MilCodeGen.
Regression
Kinda, MilCodeGen won't work without suppressing warnings now.
Testing
Local build, codegen run.
Risk
None.
Microsoft Reviewers: Open in CodeFlow