fix: issue with empty prior_values list #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ValueError when passing mode=sum to log_metric
Observed Behavior:
When you
log_metric("some_metric", some_number, mode="sum")
, the SDK raises the following error. This does not occur for any other aggregation modes.Resolution:
I swapped the summation method for an approach that can handle an empty list.
Generated Summary:
Metric
class to modify how values are aggregated in "sum" mode.max(prior_values)
tosum([self.value, *prior_values])
.This summary was generated with ❤️ by rigging