Skip to content

Add header + Remove unsafe usage #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2020
Merged

Add header + Remove unsafe usage #11

merged 3 commits into from
Jan 19, 2020

Conversation

Shadlock0133
Copy link
Contributor

@Shadlock0133 Shadlock0133 commented Jan 19, 2020

I've added header to output, so the columns are hopefully more obvious:

  Lines Copies  Function name
   3062    173  core::ptr::real_drop_in_place
    966      2  alloc::slice::merge_sort
    812      2  alloc::raw_vec::RawVec<T,A>::reserve_internal
    612      2  alloc::slice::insert_head
    586      1  cargo_llvm_lines::read_llvm_ir

I've also noticed one unsafe function, which I don't understand why is it needed. I replaced it with hopefully correct, safe code. I tested it only on Windows, so if it's wrong/breaks on Linux, I can remove the commit.

Edit: Forgot about rustfmt.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The create_stdios code might be from before child streams were usable as Stdio (rust-lang/rust#42133).

@dtolnay dtolnay merged commit 0e9cae6 into dtolnay:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants