Skip to content

🔧 use confirmed trips for agg metrics #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JGreenlee
Copy link
Contributor

Step 1 of e-mission/e-mission-docs#1126 is to simply use confirmed trips instead of composite trips to compute metrics. Confirmed trips are smaller than composite trips, so this will use less memory. e-mission-common is already set up to handle both types the same way.

Testing done:
e-mission/e-mission-docs#1126 (comment)

Step 1 of e-mission/e-mission-docs#1126 is to simply use confirmed trips instead of composite trips to compute metrics. Confirmed trips are smaller than composite trips, so this will use less memory.
e-mission-common is already set up to handle both types the same way.

Testing done:
e-mission/e-mission-docs#1126 (comment)
Copy link
Contributor

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved, but I am going to keep it in my "back pocket" while seeing how long it takes to implement the "cache once a day, as part of the public dashboard" solution.

@shankari shankari force-pushed the master branch 4 times, most recently from a2a9a44 to e50e9f3 Compare June 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants