Skip to content

Non-Test Changes for Rule Engine #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Non-Test Changes for Rule Engine #1058

wants to merge 2 commits into from

Conversation

TeachMeTW
Copy link
Contributor

@TeachMeTW TeachMeTW commented Apr 24, 2025 •
edited
Loading

This PR implements two main changes:

Rule Engine Migration:

  • Migrates mode inference to use rule_engine for improved maintainability and performance
  • Enables more consistent handling of mode inference rules
  • Addresses issues with existing mode inference implementation

Transit Matching Caching:

  • Implements caching mechanism for Overpass API results in match_stops.py
  • Significantly reduces API calls to external services
  • Improves performance for repeated transit matching operations
  • Cache files are stored as JSON for easy inspection and debugging

Related Issues:

@TeachMeTW TeachMeTW changed the title Migrated to rule_engine for mode inference and added transit matching… Non-Test Changes for Rule Engine Apr 24, 2025
@TeachMeTW TeachMeTW force-pushed the pr_split_non_tests branch from b6edff9 to 529251c Compare April 25, 2025 01:52
@TeachMeTW TeachMeTW mentioned this pull request Apr 25, 2025
Closed
@TeachMeTW TeachMeTW marked this pull request as ready for review April 25, 2025 02:04
@TeachMeTW TeachMeTW marked this pull request as draft April 25, 2025 20:37
@TeachMeTW TeachMeTW marked this pull request as ready for review April 29, 2025 06:23
@shankari shankari force-pushed the master branch 4 times, most recently from a2a9a44 to e50e9f3 Compare June 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TeachMeTW