Skip to content

Csv timeseries #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Csv timeseries #1063

wants to merge 4 commits into from

Conversation

KG2468
Copy link

@KG2468 KG2468 commented May 2, 2025

#1121

@shankari
Copy link
Contributor

shankari commented May 3, 2025

@KG2468 couple of high level comments before @JGreenlee and I review this

Are the files in emission/storage/timeseries/data/ the raw files that you downloaded from the TSDC?

If so (I can't view them because they are too large), they should not be checked in to the repo.

  1. The files are not currently fully public; people can download them from the TSDC, but they have to register and click through the terms and conditions
  2. While you can and should test against them, we are building a system that will work with any csv file, not a one-off script to process a particular dataset

When you remove the files, please make sure to edit your commit (git rebase -i HEAD~3 or similar) to remove the files completely instead of introducing a new commit to remove them. Unless you edit the commit, the files will be in git history so will still be accessible via the correct git checkout

Improve the PR to be more meaningful

  1. Please edit the PR title and description to summarize what you are doing
  2. Please indicate "Testing done"

@shankari shankari force-pushed the master branch 4 times, most recently from a2a9a44 to e50e9f3 Compare June 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants