Skip to content

Add server and result level stats storage #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2014

Conversation

shankari
Copy link
Contributor

@shankari shankari commented Dec 4, 2014

The server stats are automatically stored using the before and after hooks. We
store the uuid and the start time in the request in the before hook, and
compute the duration and store the entry in the after hook.

For the result stats, I just inserted entries at various parts of the code. The
entries are inserted using constants defined in the stats file, so that we know
what all of them are.

I added a new unit test case for the calculation of the sum, and tested that
the stats are inserted correctly manually due to lack of time. A unit test is
pending and will be checked in soon.

All this code is exercised using existing unit tests, all of which pass. The
storage code is copied from the client stats code, which is known to work. For
completeness, we just need to add a new unit test testing that the generated
stats are indeed stored correctly in the database.

I have filed an issue to track this.

The server stats are automatically stored using the before and after hooks. We
store the uuid and the start time in the request in the before hook, and
compute the duration and store the entry in the after hook.

For the result stats, I just inserted entries at various parts of the code. The
entries are inserted using constants defined in the stats file, so that we know
what all of them are.

I added a new unit test case for the calculation of the sum, and tested that
the stats are inserted correctly manually due to lack of time. A unit test is
pending and will be checked in soon.

All this code is exercised using existing unit tests, all of which pass. The
storage code is copied from the client stats code, which is known to work. For
completeness, we just need to add a new unit test testing that the generated
stats are indeed stored correctly in the database.

I have filed an issue to track this.
When I created the different stats categories
@shankari
Copy link
Contributor Author

shankari commented Dec 4, 2014

The unit tests are being tracked in issue #35

shankari added a commit that referenced this pull request Dec 4, 2014
Add server and result level stats storage
@shankari shankari merged commit f640bd4 into e-mission:master Dec 4, 2014
humbleOldSage pushed a commit to humbleOldSage/e-mission-server that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant