Skip to content

Fix namespace issue for BinarySecurityToken tag#29

Closed
jeffcarbs wants to merge 2 commits intoebeigarts:masterfrom
jeffcarbs:fix-binary-security-token-node
Closed

Fix namespace issue for BinarySecurityToken tag#29
jeffcarbs wants to merge 2 commits intoebeigarts:masterfrom
jeffcarbs:fix-binary-security-token-node

Conversation

@jeffcarbs
Copy link
Copy Markdown

@jeffcarbs jeffcarbs commented Aug 16, 2021

In nokogiri 1.12.0 the following change was introduced:

[CRuby] Reparented nodes no longer inherit their parent's namespace. Previously, a node without a namespace was forced to adopt its parent's namespace. [https://github.com/sparklemotion/nokogiri/issues/1712, https://github.com/sparklemotion/nokogiri/issues/425]

It seems like the BinarySecurityToken was implicitly relying on this to add the wsse: prefix which is no longer happening. This PR fixes it by explicitly adding the namespace.

@jeffcarbs jeffcarbs force-pushed the fix-binary-security-token-node branch from 21cc9ae to a53e600 Compare August 16, 2021 19:28
Co-authored-by: Bernard Pietraga <16989065+bpietraga@users.noreply.github.com>
@bjensen
Copy link
Copy Markdown

bjensen commented Aug 24, 2021

👍

@jweir
Copy link
Copy Markdown

jweir commented Aug 30, 2021

Running this patch against a test in our system works, but for some reason #31 is still producing a BinarySecurityToken tag without the namespace.

@ebeigarts
Copy link
Copy Markdown
Owner

@jweir I have released #31 in signer v1.10.0 and the tests are green now with nokogiri 1.12.5, please try signer v1.10.0 and reopen/rebase with test cases if there is still an issue.

@ebeigarts ebeigarts closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants