Clean-up integration tests and improve re-use of pomless projects #4772
+50
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
added
the
backport-to-tycho-4.0.x
HannesWell
force-pushed
the
clean-up-integration-tests
branch
from
912d49f to
0f7607f
Compare
Test Results 609 files 609 suites 4h 20m 58s ⏱️ For more details on these failures, see this check. Results for commit a8fbbb0. ♻️ This comment has been updated with latest results. |
If tycho-pomless is used in (integration) test-resources/projects the entire project structure, especially including the '.mvn' folder has to be copied into the clean test-environment, even if just a sub-project is executed. This extends AbstractTychoIntegrationTest.getVerifier() to add overloads that allow to specify the project-structure root and the specific sub-folder that is eventually executed.
HannesWell
force-pushed
the
clean-up-integration-tests
branch
3 times, most recently
from
0d89b36 to
38b982a
Compare
HannesWell
force-pushed
the
clean-up-integration-tests
branch
from
38b982a to
a8fbbb0
Compare
laeubi
removed
the
backport-to-tycho-4.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tycho-pomless is used in (integration) test-resources/projects the entire project structure, especially including the '.mvn' folder has to be copied into the clean test-environment, even if just a sub-project is executed.
This extends AbstractTychoIntegrationTest.getVerifier() to add overloads that allow to specify the project-structure root and the specific sub-folder that is eventually executed.
There are probably more integration that could be cleaned-up with this, but as a first step I have only used it in one place.