Skip to content

ESS - Change current to MS-62 #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Conversation

kilfoyle
Copy link
Contributor

This changes "current" for the Cloud ESS docs to MS-62.

@gtback
Copy link
Member

gtback commented Sep 1, 2021

@kilfoyle I updated this with the changes from #2205. I also took the liberty of pulling the "current" Cloud MS branch into a variable, so future PRs can contain a single change.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 1, 2021

@gtback Brilliant! Just one line to change.
Thanks for pushing this!

@gtback
Copy link
Member

gtback commented Sep 1, 2021

@kilfoyle I'm not sure why the build is failing (it looks like it's broken links). I'm not sure if something has changed in the cloud repo since your initial commit, or if it's related to the changes I just made. Do you have a chance to take a look?

16:56:03 INFO:build_docs:Bad cross-document links:
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.10/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.11/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.12/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.13/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.14/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.15/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.7/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.8/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.9/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/7.x/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/current/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/app-search/master/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-heroku/current/ech-restrictions.html contains broken links to:
16:56:03 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-heroku/latest/ech-restrictions.html contains broken links to:
16:56:03 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud/current/ec-restrictions.html contains broken links to:
16:56:03 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud/latest/ec-restrictions.html contains broken links to:
16:56:03 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.10/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.11/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.12/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.13/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.14/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.15/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.7/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.8/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.9/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/7.x/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/current/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search/master/installation.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.10/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.11/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.12/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.13/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.14/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.15/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.7/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.8/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.9/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/7.x/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/current/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search
16:56:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/workplace-search/master/workplace-search-install.html contains broken links to:
16:56:03 INFO:build_docs:   - en/cloud/current/ec-getting-started-solutions.html#ec-getting-started-enterprise-search

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 2, 2021

@gtback It looks like it's related to changes from https://github.com/elastic/cloud/pull/87391 which removed the page ec-getting-started-solutions.html.

Here's the link on the Enterprise Search Installation page.
Screen Shot 2021-09-01 at 8 28 12 PM

I'll open a PR for the Enterprise Search, App Search, and Workplace Search docs.

CC @alaudazzi

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 2, 2021

This PR (https://github.com/elastic/enterprise-search-pubs/pull/1380) should hopefully fix all of the broken links from the Enterprise Search, App Search, and Workplace Search docs to the Cloud "What are Solutions?" page that we removed in MS-62.

@nrichers, four of the links in the build error log that Greg posted above appear to have been added by the Fix APM and Fleet Restrictions PR. They point to en/kibana/7.14/agent-configuration.html. Would you mind checking on those ones?

@gtback
Copy link
Member

gtback commented Sep 2, 2021

@elasticmachine run elasticsearch-ci/docs

@gtback
Copy link
Member

gtback commented Sep 2, 2021

@kilfoyle I'm running this again to get a (hopefully) smaller list of broken links.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 2, 2021

Looking better!

11:05:19 INFO:build_docs:Bad cross-document links:
11:05:20 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-heroku/current/ech-restrictions.html contains broken links to:
11:05:20 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
11:05:20 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-heroku/latest/ech-restrictions.html contains broken links to:
11:05:20 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
11:05:20 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud/current/ec-restrictions.html contains broken links to:
11:05:20 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM
11:05:20 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud/latest/ec-restrictions.html contains broken links to:
11:05:20 INFO:build_docs:   - en/kibana/7.14/agent-configuration.html[APM

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 2, 2021

@elasticmachine run elasticsearch-ci/docs

@bobbybho bobbybho merged commit 5b6ac79 into elastic:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants