Self-Test: Add html diffing #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare the html built by AsciiDoc and Asciidoctor as part of the self-test. Like all good tests, it doesn't pass at first. I've temporarilly ignored all of the failures and have added them to the main asciidoctor issue or filed them as their own issue.
ddillinger
approved these changes
Feb 22, 2019
| @@ -14,6 +14,7 @@ LABEL MAINTAINERS="Nik Everett <[email protected]>" | |||
| # * openssh-client (used by git) | |||
| # * openssh-server (used to forward ssh auth for git when running with --all on macOS) | |||
| # * perl-base | |||
| # * python (is python2) | |||
There was a problem hiding this comment.
This reminds me. Is there an issue for changing to python 3, and explicitly weeding out and dropping support for python 2 wherever it may be found? Because python 2 has less than a year to live. I didn't see one on a quick issue search, but I might have just missed it.
There was a problem hiding this comment.
Not really, no. But, hey, I'll make one.
|
Thanks for reviewing @ddillinger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare the html built by AsciiDoc and Asciidoctor as part of the
self-test. Like all good tests, it doesn't pass at first. I've
temporarilly ignored all of the failures and have added them to the
main asciidoctor issue or filed them as their own issue.