Move commit related stuff to stateless #139263
Draft
+5,094
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingherc
added
>non-issue
:Distributed Indexing/Distributed
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates commit-related classes and functionality from one location to the stateless plugin module, along with related thread pool configurations. The changes support the stateless architecture by consolidating commit management, blob storage handling, and resource allocation in a centralized location.
Key changes:
- Migration of core commit classes (
StatelessCompoundCommit,BatchedCompoundCommit,VirtualBatchedCompoundCommit) and supporting types - Addition of thread pool configurations for stateless operations
- Implementation of test utilities and comprehensive test coverage for migrated classes
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| PrimaryTermAndGenerationTests.java | Test suite for primary term and generation tracking |
| VirtualBatchedCompoundCommitTestUtils.java | Test utilities for virtual batched compound commits |
| StatelessCompoundCommitTests.java | Comprehensive tests for stateless compound commit functionality |
| StatelessCompoundCommitTestUtils.java | Helper utilities for creating test instances |
| StatelessCompoundCommitInternalFileTests.java | Tests for internal file sorting logic |
| ReplicatedContentTests.java | Tests for replicated content handling in commits |
| InternalFilesReplicatedRangesTests.java | Tests for replicated range serialization |
| BlobLocationTests.java | Tests for blob location handling |
| BlobLocationTestUtils.java | Test utilities for blob locations |
| BlobFileRangesTestUtils.java | Test utilities for blob file ranges |
| Lucene90CompoundEntriesReaderTests.java | Tests for compound file entry reading |
| StatelessCommitRef.java | Wrapper for Lucene commits with additional stateless metadata |
| PrimaryTermAndGeneration.java | Record for tracking primary term and generation pairs |
| NewCommitNotification.java | Notification record for newly created compound commits |
| VirtualBatchedCompoundCommit.java | Implementation of virtual batched compound commits with ref-counting |
| StatelessCompoundCommit.java | Core implementation of stateless compound commits |
| ReplicatedContent.java | Implementation of replicated content for compound commits |
| InternalFilesReplicatedRanges.java | Representation of replicated byte ranges in commits |
| ClosedShardService.java | Service for managing state of closed shards |
| BlobLocation.java | Record representing file locations within blob storage |
| BlobFileRanges.java | Implementation for determining read positions in blob files |
| BlobFile.java | Record representing blob files in storage |
| BatchedCompoundCommit.java | Implementation of batched compound commits |
| AbstractBatchedCompoundCommit.java | Interface for batched compound commit implementations |
| Lucene90CompoundEntriesReader.java | Reader for Lucene 90 compound file entries |
| StatelessPlugin.java | Plugin configuration with thread pool setup |
| module-info.java | Module descriptor with updated dependencies and exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ss/src/test/java/org/elasticsearch/xpack/stateless/commits/StatelessCompoundCommitTests.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
serverless-linked
Migrating: * PrimaryTermAndGeneration * ClosedShardService * BlobFile * BatchedCompoundCommit * Blob ranges * ReplicatedContent * VirtualBatchedCompoundCommit and related functionality and tests. Relates ES-13590
kingherc
force-pushed
the
non-issue/ES-13590-stateless-commits
branch
from
7a5eca9 to
8c22e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating:
and related functionality and tests.
Also migrating thread pools.
Relates ES-13590