Include denial reason info in checkFileRead #139277
Open
+85
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
>non-issue
:Core/Infra/Entitlements
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v9.1.9
v8.19.9
v9.2.3
and removed
branch:9.2
branch:9.1
branch:8.19
labels
rjernst
reviewed
Dec 9, 2025
| throw e; // rethrow | ||
| } catch (IOException e) { | ||
| canRead = false; | ||
| denialReason = e.toString(); |
Member
There was a problem hiding this comment.
rather than wrap this as an entitlement error, why not widen the NoSuchFileException above to IOException? ie just rethrow any IOException. This would allow the caller to act (eg by retrying the operation if it knows it's a network file system). This really shouldn't be an entitlement error, it's a filesystem error that is getting confused for an entitlement problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In entitlements, we currently catch and swallow
IOExceptionencountered during a read check of a symlink. This is necessary because anIOExceptionis how the Java API tells us that permission has been denied.The trouble is, if other IOExceptions happen, like weird filesystem situations, we discard that information and simply report that permission is denied, which can be confusing.
Let's include a little bit of info about why the permission was denied.