Skip to content

[Unzyme] src/core/packages/mount-utils :shipit: #226428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

[Unzyme] src/core/packages/mount-utils :shipit: #226428

merged 1 commit into from
Jul 4, 2025
+10 −11

Conversation

jesuswr
Copy link
Contributor

@jesuswr jesuswr commented Jul 3, 2025 •
edited by kibanamachine
Loading

Summary

Resolves #224000

Moved to react testing library. Tests pass but I'm getting this warning now:

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

When I tried to move to createRoot it caused other issues so I'm not sure how to continue or if we should ignore the warning 🤔 @Dosant

@jesuswr jesuswr changed the title [Unzyme] src/core/packages/mount-utils [Unzyme] src/core/packages/mount-utils :shipit: Jul 3, 2025
@jesuswr
Copy link
Contributor Author

jesuswr commented Jul 3, 2025

/ci

@jesuswr jesuswr self-assigned this Jul 3, 2025
@jesuswr jesuswr added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 3, 2025
@Dosant
Copy link
Contributor

Dosant commented Jul 3, 2025

Warning is ok, imo good to ignore and proceed. mountReactNode should be migrate to createRoot later with concurrent mode migration

@jesuswr jesuswr marked this pull request as ready for review July 3, 2025 15:28
@jesuswr jesuswr requested a review from a team as a code owner July 3, 2025 15:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jesuswr jesuswr mentioned this pull request Jul 3, 2025
Open
9 tasks
@jesuswr jesuswr added backport:prev-minor Backport to (9.1) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jul 3, 2025
gsoldevila
gsoldevila approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jesuswr jesuswr merged commit 1e03b3a into elastic:main Jul 4, 2025
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16069263450

@jesuswr jesuswr deleted the unzyme-22400 branch July 4, 2025 08:25
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 4, 2025
@jesuswr
[Unzyme] src/core/packages/mount-utils :shipit: (elastic#226428)
d1ba1e0 
## Summary

Resolves elastic#224000

Moved to react testing library. Tests pass but I'm getting this warning
now:

```
Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot
```

When I tried to move to createRoot it caused other issues so I'm not
sure how to continue or if we should ignore the warning 🤔 @Dosant

(cherry picked from commit 1e03b3a)
@kibanamachine kibanamachine mentioned this pull request Jul 4, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 4, 2025
@kibanamachine @jesuswr
[9.1] [Unzyme] src/core/packages/mount-utils :shipit: (#226428) (#226534)
376ffa5 
# Backport

This will backport the following commits from `main` to `9.1`:
- [[Unzyme] `src/core/packages/mount-utils` :shipit:
(#226428)](#226428)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jesus
Wahrman","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-04T08:21:08Z","message":"[Unzyme]
`src/core/packages/mount-utils` :shipit: (#226428)\n\n##
Summary\n\nResolves
https://github.com/elastic/kibana/issues/224000\n\nMoved to react
testing library. Tests pass but I'm getting this
warning\nnow:\n\n```\nWarning: ReactDOM.render is no longer supported in
React 18. Use createRoot instead. Until you switch to the new API, your
app will behave as if it's running React 17. Learn more:
https://reactjs.org/link/switch-to-createroot\n```\n\nWhen I tried to
move to createRoot it caused other issues so I'm not\nsure how to
continue or if we should ignore the warning 🤔
@Dosant","sha":"1e03b3a3853d82fe2b9fbf9a67f8e274e2d4f164","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical
debt","release_note:skip","backport:prev-minor","v9.2.0"],"title":"[Unzyme]
`src/core/packages/mount-utils`
:shipit:","number":226428,"url":"https://github.com/elastic/kibana/pull/226428","mergeCommit":{"message":"[Unzyme]
`src/core/packages/mount-utils` :shipit: (#226428)\n\n##
Summary\n\nResolves
https://github.com/elastic/kibana/issues/224000\n\nMoved to react
testing library. Tests pass but I'm getting this
warning\nnow:\n\n```\nWarning: ReactDOM.render is no longer supported in
React 18. Use createRoot instead. Until you switch to the new API, your
app will behave as if it's running React 17. Learn more:
https://reactjs.org/link/switch-to-createroot\n```\n\nWhen I tried to
move to createRoot it caused other issues so I'm not\nsure how to
continue or if we should ignore the warning 🤔
@Dosant","sha":"1e03b3a3853d82fe2b9fbf9a67f8e274e2d4f164"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226428","number":226428,"mergeCommit":{"message":"[Unzyme]
`src/core/packages/mount-utils` :shipit: (#226428)\n\n##
Summary\n\nResolves
https://github.com/elastic/kibana/issues/224000\n\nMoved to react
testing library. Tests pass but I'm getting this
warning\nnow:\n\n```\nWarning: ReactDOM.render is no longer supported in
React 18. Use createRoot instead. Until you switch to the new API, your
app will behave as if it's running React 17. Learn more:
https://reactjs.org/link/switch-to-createroot\n```\n\nWhen I tried to
move to createRoot it caused other issues so I'm not\nsure how to
continue or if we should ignore the warning 🤔
@Dosant","sha":"1e03b3a3853d82fe2b9fbf9a67f8e274e2d4f164"}}]}]
BACKPORT-->

Co-authored-by: Jesus Wahrman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@gsoldevila gsoldevila gsoldevila approved these changes

Assignees

@jesuswr jesuswr

Labels
backport:prev-minor Backport to (9.1) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v9.1.0 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unzyme] src/core/packages/mount-utils
5 participants
@jesuswr @Dosant @elasticmachine @kibanamachine @gsoldevila