[ML] Anomaly Detection Alerting: Mark User Errors #226586
Merged
+57
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtj
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
…urce-definitions/scripts/fix-location-collection.ts'
darnautov
approved these changes
Jul 7, 2025
| return true; | ||
| } | ||
|
|
||
| if ((err as any)?.statusCode === 404) { |
There was a problem hiding this comment.
let's avoid using any, something like this should work
Suggested change
| if ((err as any)?.statusCode === 404) { | |
| if (typeof err === 'object' && Object.hasOwn(err, 'statusCode') && err.statusCode === 404) { |
There was a problem hiding this comment.
Object.hasOwn(..) doesn't provide type narrowing, so err.statusCode causes an error in your example.
I came up with smth like this:
if (err !== null && typeof err === 'object' && 'statusCode' in err && err.statusCode === 404) {
return true;
}
There was a problem hiding this comment.
'statusCode' in err is also true if statusCode exist in the prototype chain. the important part in you need to add it err !== null, the rest could remain the same.
There was a problem hiding this comment.
improved check in a6d469c
💚 Build Succeeded
Metrics [docs]
History
cc @rbrtj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #212332
This PR marks errors such as
No jobs found..,No datafeed foundas user errors to prevent them from affecting SLOs and alerts.However, there are additional errors that require further investigation, which will be addressed in a follow-up.