Skip to content

[ES|QL] Move functionality from RRF to FUSE #226743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 7, 2025

Summary

Just moves all our functionality from RRF to FUSE and removes the after fork rule as now it is supported everywhere

RRF is going to be removed by the ES team

});

// ToDo:n Enable when RRF is on tech preview
it.skip('suggests RRF immediately after a FORK command', async () => {
// ToDo:n Enable when FUSE is on tech preview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we ended up removing this restriction for FUSE - it does not have to always follow after FORK anymore.
up to you when you want to remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌 I did it here 2f21206

Thnx for letting me know

@stratoula stratoula added v9.2.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jul 7, 2025
@stratoula stratoula marked this pull request as ready for review July 7, 2025 13:18
@stratoula stratoula requested a review from a team as a code owner July 7, 2025 13:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +9.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.8MB 3.8MB -418.0B

History

Copy link
Contributor

@sddonne sddonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stratoula stratoula merged commit 38f1581 into elastic:main Jul 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants