-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Fleet] Fix agent status badge when stuck upgrading #226893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Fleet] Fix agent status badge when stuck upgrading #226893
Conversation
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
… than stuck for showing badge
…ementing/kibana into fix-agent-status-table-fix
status: Agent['status']; | ||
inFailedUpgradeState: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels a bit odd to introduce a new prop just for this specific sub-state.. I wonder if we can just accept the agent upgrade details information like this:
status: Agent['status']; | |
inFailedUpgradeState: boolean; | |
status: Agent['status']; | |
upgradeDetails?: Agent['upgrade_details']; |
and then use isAgentInFailedUpgradeState()
directly in this component to derive the badge. WDYT?
then this component could show other upgrade sub-states in the future if we choose to (I see 9 of them in AgentUpgradeStateType
!)
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Summary
Closes #5785
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesbackport:*
labels.Identify risks
N/A