allow numbers in reddit post_id #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checker just checked against URIs... |
efa2d19
reviewed
Jul 20, 2022
| @@ -13,7 +13,7 @@ random = { optional = true, options = [true, | |||
| false, | |||
| ], default = false, type = "bool", explanation = "If set to no, it will ask you a thread link to extract the thread, if yes it will randomize it. Default: 'False'", example = "True" } | |||
| subreddit = { optional = false, regex = "[_0-9a-zA-Z]+$", nmin = 3, explanation = "what subreddit to pull posts from, the name of the sub, not the URL", example = "AskReddit", oob_error = "A subreddit name HAS to be between 3 and 20 characters" } | |||
| post_id = { optional = true, default = "", regex = "^((?!://|://)[+a-zA-Z])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } | |||
| post_id = { optional = true, default = "", regex = "^((?!://|://)[+a-zA-Z0-9])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } | |||
There was a problem hiding this comment.
why not just \w?
Suggested change
| post_id = { optional = true, default = "", regex = "^((?!://|://)[+a-zA-Z0-9])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } | |
| post_id = { optional = true, default = "", regex = "^((?!://|://)[+\w])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } |
There was a problem hiding this comment.
/w would allow _ as well, which cannot be part of a post_id
There was a problem hiding this comment.
good point, what about this?
Suggested change
| post_id = { optional = true, default = "", regex = "^((?!://|://)[+a-zA-Z0-9])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } | |
| post_id = { optional = true, default = "", regex = "^((?!://|://)[+\w][^_])*$", explanation = "Used if you want to use a specific post.", example = "urdtfx" } |
There was a problem hiding this comment.
could work, but imho a-zA-Z0-9 is much easier to read
Yeah, there is negative lookahead for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reddit Threads can have numbers in them, so the regex should allow that
Issue Fixes
None
Checklist:
Any other information (e.g how to test the changes)
None