Skip to content

Bot can run multiple instances at the same time #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 9, 2022

Conversation

OpenSourceSimon
Copy link
Collaborator

Description

With this pull request you can use the program multiple times at the same time. This is because the temp folder is determined per folder. For example: if the video id is 12356, then the temp folder is assets/temp/123456/png . If you run another instance with the id 67890 then the temp folder is assets/temp/67890/png .

Issue Fixes

None

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

None

Copy link
Collaborator

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just those few things that could be improved

@OpenSourceSimon OpenSourceSimon requested a review from callumio July 29, 2022 12:49
@github-actions github-actions bot added the stale label Aug 6, 2022
@OpenSourceSimon
Copy link
Collaborator Author

Any reason this isn't merged yet?

@JasonLovesDoggo
Copy link
Collaborator

Any reason this isn't merged yet?

Waiting for @callumio s review

@callumio callumio merged commit 5a8db46 into elebumm:develop Aug 9, 2022
@MarkelAdanez
Copy link

It keeps makes the same video in the different instace, is this only me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants