limit filename to 255 chars #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JasonLovesDoggo merged 1 commit into elebumm:develop from swoker:patch-1

Aug 6, 2022

Contributor

swoker commented Aug 5, 2022

Description

255 characters is the max length for filenames on windows
if the reddit post title is too long, the video will not be created.

Example Post ID for testing: wezcd4

Checklist:

I am pushing changes to the develop branch
I am using the recommended development environment
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have formatted and linted my code using python-black and pylint
I have cleaned up unnecessary files
My changes generate no new warnings
My changes follow the existing code-style
My changes are relevant to the project


          limit filename to 255 chars

7132bd6

max length for filenames on windows

Collaborator

callumio commented Aug 5, 2022

Truncating the file name is a much better idea than just not creating the video

Collaborator

JasonLovesDoggo commented Aug 6, 2022 •

edited

Loading

I had this already who removed it....... Bruh

JasonLovesDoggo merged commit 9e37b40 into elebumm:develop

swoker deleted the patch-1 branch

August 11, 2022 07:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet