Minor changes to #990 (fixed audio glitches caused by previous audio concatenation method) #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmny
changed the title
thomasmny
changed the title
|
Will review later |
JasonLovesDoggo
approved these changes
Aug 22, 2022
|
works perfectly thank you @Trichtern this is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All credit for this PR goes to @tonywiththetommy
However his PR has been stale for a while and accumulated some merge conflicts so I decided to redo the PR in hope that it can be merged soon.
Also adds
silence_durationto the config template which upstream didn't.Issue Fixes
Superceeds #990
Checklist:
Any other information (e.g how to test the changes)
None