Skip to content

Mobile view - Create index.html #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Mobile view - Create index.html #960

merged 1 commit into from
Jul 11, 2022

Conversation

muhammedaksam
Copy link
Contributor

@muhammedaksam muhammedaksam commented Jul 11, 2022

Created index.html file for quick access to video via another device.

Description

A JSON viewer front-end to easily download video and copy descriptions for different platforms.

To acces this index.html file from another device you should run python -m http.server 8000 command from your CMD that prompted over your RedditVideoMakerBot folder. You can change 8000 with any other port you want. After that all you need to do is learn your local IPv4 Address. To do that simply write ipconfig to another CMD tab.

ss2022-07-11 200733

You can customize your copy text from data-clipboard-text attributes or add new buttons with different texts.

Currently I noticed there is a few issue with this. You can't playback the videos, only download. Also I only tested with iOS device. And as I saw you can't Download with Chrome. download attribute for link doesn't work with Chrome&iOS. However you can use Safari.

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

Run python -m http.server 8000 and visit ip-address:port from your mobile device.

Ekran görüntüsü 2022-07-11 202855

Created index.html file for quick access to video via another device.
@muhammedaksam muhammedaksam changed the base branch from master to develop July 11, 2022 17:32
@JasonLovesDoggo JasonLovesDoggo merged commit a4149e1 into elebumm:develop Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants