Use 'setfiletype' to set local &filetype #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'setfiletype' is nice in these cases because it prevents &filetype from being set redundantly. Note that the Vim runtime ships with a filetype match for *.ex (for Euphoria), but our plugin-based filetype detection still gets the last say. Also, use 'setlocal' when setting &filetype in the shebang detection path. We don't want to use 'setfiletype' here because it's possible we need to override an existing syntax assignment, and we already guard against setting &filetype to 'elixir' twice.
jbodah
added a commit
that referenced
this pull request
Feb 14, 2019
kelvinst
pushed a commit
to kelvinst/vim-elixir
that referenced
this pull request
Aug 21, 2019
'setfiletype' is nice in these cases because it prevents &filetype from being set redundantly. Note that the Vim runtime ships with a filetype match for *.ex (for Euphoria), but our plugin-based filetype detection still gets the last say. Also, use 'setlocal' when setting &filetype in the shebang detection path. We don't want to use 'setfiletype' here because it's possible we need to override an existing syntax assignment, and we already guard against setting &filetype to 'elixir' twice.
kelvinst
pushed a commit
to kelvinst/vim-elixir
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'setfiletype' is nice in these cases because it prevents &filetype from
being set redundantly.
Note that the Vim runtime ships with a filetype match for *.ex (for
Euphoria), but our plugin-based filetype detection still gets the last
say.
Also, use 'setlocal' when setting &filetype in the shebang detection
path. We don't want to use 'setfiletype' here because it's possible we
need to override an existing syntax assignment, and we already guard
against setting &filetype to 'elixir' twice.