-
Notifications
You must be signed in to change notification settings - Fork 220
Closed
Labels
Description
Environment
- Elixir & Erlang versions (elixir --version): Elixir 1.15.5, OTP 26.0.2
- Elixir Language Server version: 0.16.0
- Operating system: Mac OS (Intel, latest)
- Editor or IDE name (e.g. Emacs/VSCode): VSCode
- Editor Plugin/LSP Client name and version: jakebecker.elixir-ls 0.16.0
Current behavior
After updating to Elixir 1.15.5 ~H sigils are no longer formatted by the VSCode ElixirLS plugin. To reproduce, generate a new Phoenix project with mix phx.new example
. The generated ExampleWeb.CoreComponents
module contains ~H sigils that can be used for testing and the generated .formatter.exs
file includes plugins: [Phoenix.LiveView.HTMLFormatter]
. Running mix format
from the command line will result in the ~H sigils being formatted. But if the formatter is run by ElixirLS then the Elixir code is formatted but not the ~H sigils.
Downgrading to Elixir 1.15.4 fixes the problem.
Expected behavior
I would expect ~H sigils to be formatted by ElixirLS as it was prior to Elixir version 1.15.5.
Thanks.
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
lukaszsamson commentedon Aug 30, 2023
Thanks for the report. There were formatter plugin related changes in 1.15.5. I will investigate
champeric commentedon Sep 6, 2023
I just want to chime in that I have the exact same problem with the same environment.
stevencorona commentedon Sep 6, 2023
I've had the same issue but specifically within an umbrella project - @lukaszsamson @champeric are you both working in umbrella projects as well?
It also seems to work sporatically, almost like it's using the wrong .formatter.exs configuration for the wrong project app.
lukaszsamson commentedon Sep 14, 2023
Thanks for reporting. This is a regression in elixir 1.15.5
lukaszsamson commentedon Sep 14, 2023
Already fixed upstream and backported to 1.15 branch. 1.16 and 1.15.6 releases should not be affected by this bug
balexand commentedon Sep 15, 2023
Thanks!