Skip to content

feat: add ssl opt to httpc by default#626

Merged
yordis merged 4 commits intomasterfrom
add-ssl-to-httpc-by-default
Aug 1, 2024
Merged

feat: add ssl opt to httpc by default#626
yordis merged 4 commits intomasterfrom
add-ssl-to-httpc-by-default

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented Oct 10, 2023

fixes #293

Signed-off-by: Yordis Prieto yordis.prieto@gmail.com

@yordis yordis force-pushed the add-ssl-to-httpc-by-default branch 6 times, most recently from cf9bb33 to 519a138 Compare October 10, 2023 23:09
@yordis yordis force-pushed the add-ssl-to-httpc-by-default branch 5 times, most recently from ee7f55a to 14cd5f6 Compare July 1, 2024 06:10
@yordis
Copy link
Copy Markdown
Member Author

yordis commented Jul 1, 2024

@maennchen do you know what am I am doing wrong that the SSL is not returning an error, but logging it

Notice: badssl expired.badssl.com [L#52]2024-07-01 06:12:48.276 [notice] TLS :client: In state :certify at ssl_handshake.erl:2109 generated CLIENT ALERT: Fatal - Certificate Expired

https://github.com/elixir-tesla/tesla/actions/runs/9739093158/job/26873718685?pr=626#step:6:1048

@yordis yordis force-pushed the add-ssl-to-httpc-by-default branch from 14cd5f6 to 5efb69b Compare July 11, 2024 21:35
yordis added 3 commits July 31, 2024 23:14
fixes #293

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the add-ssl-to-httpc-by-default branch 8 times, most recently from 8f5e0a5 to 8bd15b9 Compare August 1, 2024 14:47
@yordis yordis requested review from maennchen and teamon and removed request for maennchen August 1, 2024 14:48
@yordis yordis marked this pull request as ready for review August 1, 2024 14:48
@yordis yordis force-pushed the add-ssl-to-httpc-by-default branch from 8bd15b9 to fc45aac Compare August 1, 2024 14:50
@yordis yordis force-pushed the add-ssl-to-httpc-by-default branch from fc45aac to c534b28 Compare August 1, 2024 15:00
@yordis
Copy link
Copy Markdown
Member Author

yordis commented Aug 1, 2024

@teamon @maennchen ready to code review 🙏🏻

Copy link
Copy Markdown
Member

@teamon teamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 🙇‍♂️

@yordis yordis merged commit 63502b2 into master Aug 1, 2024
@yordis yordis deleted the add-ssl-to-httpc-by-default branch August 1, 2024 15:06
yordis added a commit that referenced this pull request Aug 5, 2024
yordis added a commit that referenced this pull request Aug 5, 2024
Revert "feat: add ssl opt to httpc by default (#626)"

This reverts commit 63502b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secure by default

3 participants