Skip to content

fix: fix imageModelProvider apiKey selection fallback #1272

Merged
mcp97 merged 5 commits into
elizaOS:developfrom
its-DeFine:bug-1270-incorrect-fallback
Dec 24, 2024
Merged

fix: fix imageModelProvider apiKey selection fallback #1272
mcp97 merged 5 commits into
elizaOS:developfrom
its-DeFine:bug-1270-incorrect-fallback

Conversation

@its-DeFine
Copy link
Copy Markdown
Contributor

@its-DeFine its-DeFine commented Dec 20, 2024

##Relates to
#1270

##Risks
None known

What does this PR do?

Introduces an addition on packages/core/src/generate.ts that first tries to match the apiKey to it's corresponding imageModelProvider and moves to the fallback logic if that fails.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

Current behaviour is not intended and causing issues and confusion.

Documentation changes needed?

Testing

Manually tested

Where should a reviewer start?

packages/core/src/generate.ts

Detailed testing steps

Deploy Notes

Database changes

Discord username

@shakkernerd shakkernerd changed the base branch from main to develop December 20, 2024 15:23
@its-DeFine its-DeFine changed the title Fix for issue 1270 fix: for issue 1270 Dec 20, 2024
@its-DeFine its-DeFine changed the title fix: for issue 1270 fix: fix imageModelProvider apiKey selection fallback Dec 20, 2024
@its-DeFine
Copy link
Copy Markdown
Contributor Author

Closed to review again and remediate issues

@its-DeFine its-DeFine closed this Dec 20, 2024
@Titan-Node
Copy link
Copy Markdown
Contributor

+1 to this pull request. Looking to add another image gen provider but waiting for this pull to fix an underlying issue.

@its-DeFine its-DeFine reopened this Dec 21, 2024
@shakkernerd shakkernerd deleted the branch elizaOS:develop December 22, 2024 07:02
@odilitime odilitime reopened this Dec 22, 2024
Copy link
Copy Markdown
Contributor

@mcp97 mcp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcp97 mcp97 merged commit 8b23c3a into elizaOS:develop Dec 24, 2024
lalalune pushed a commit that referenced this pull request May 3, 2026
fix: fix imageModelProvider apiKey selection fallback
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
fix: fix imageModelProvider apiKey selection fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants