Skip to content

fix: fix lockfile#1283

Merged
shakkernerd merged 2 commits into
elizaOS:developfrom
odilitime:fix-ts
Dec 20, 2024
Merged

fix: fix lockfile#1283
shakkernerd merged 2 commits into
elizaOS:developfrom
odilitime:fix-ts

Conversation

@odilitime
Copy link
Copy Markdown
Collaborator

Risks

Low

Background

What does this PR do?

PRs often mess with lockfile, a frozen lockfile is hiding breaking changes underneath.

If the current pnpm-lock.yaml gets deleted and then you run pnpm build, you'll get:

@ai16z/eliza:build: ✘ [ERROR] Expected identifier but found "import"
@ai16z/eliza:build: 
@ai16z/eliza:build:     (define name):1:0:
@ai16z/eliza:build:       1 │ import.meta.url
@ai16z/eliza:build:         ╵ ~~~~~~
@ai16z/eliza:build: 
@ai16z/eliza:build: Error: Build failed with 1 error:
@ai16z/eliza:build: (define name):1:0: ERROR: Expected identifier but found "import"
@ai16z/eliza:build:     at failureErrorWithLog (/root/test-prs/eliza/node_modules/esbuild/lib/main.js:1476:15)
@ai16z/eliza:build:     at /root/test-prs/eliza/node_modules/esbuild/lib/main.js:945:25
@ai16z/eliza:build:     at runOnEndCallbacks (/root/test-prs/eliza/node_modules/esbuild/lib/main.js:1316:45)
@ai16z/eliza:build:     at buildResponseToResult (/root/test-prs/eliza/node_modules/esbuild/lib/main.js:943:7)
@ai16z/eliza:build:     at /root/test-prs/eliza/node_modules/esbuild/lib/main.js:970:16
@ai16z/eliza:build:     at responseCallbacks.<computed> (/root/test-prs/eliza/node_modules/esbuild/lib/main.js:622:9)
@ai16z/eliza:build:     at handleIncomingPacket (/root/test-prs/eliza/node_modules/esbuild/lib/main.js:677:12)
@ai16z/eliza:build:     at Socket.readFromStdout (/root/test-prs/eliza/node_modules/esbuild/lib/main.js:600:7)
@ai16z/eliza:build:     at Socket.emit (node:events:507:28)
@ai16z/eliza:build:     at addChunk (node:internal/streams/readable:559:12)
@ai16z/eliza:build:  ELIFECYCLE  Command failed with exit code 1.
@ai16z/eliza:build: ERROR: command finished with error: command (/root/test-prs/eliza/packages/core) /root/test-prs/eliza/node_modules/.bin/pnpm run build exited (1)
@ai16z/eliza#build: command (/root/test-prs/eliza/packages/core) /root/test-prs/eliza/node_modules/.bin/pnpm run build exited (1)

So in the current state, we can't rebuild our lockfile. This PRs fixes that.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

We need lockfiles to be able to be regenerated

Documentation changes needed?

My changes do not require a change to the project documentation.

@shakkernerd shakkernerd merged commit 5888867 into elizaOS:develop Dec 20, 2024
lalalune pushed a commit that referenced this pull request May 3, 2026
FranceFlapjack pushed a commit to FranceFlapjack/eliza that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants